fix: some frameless windows showing a frame on Windows #32692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7694bb to
b4c71a2
Compare
zcbenz
approved these changes
Feb 1, 2022
samuelmaddock
approved these changes
Feb 2, 2022
|
Release Notes Persisted
|
This was referenced Feb 2, 2022
|
I have automatically backported this PR to "17-x-y", please check out #32707 |
|
I have automatically backported this PR to "15-x-y", please check out #32708 |
|
I have automatically backported this PR to "14-x-y", please check out #32709 |
|
I have automatically backported this PR to "16-x-y", please check out #32710 |
3 tasks
3 tasks
3 tasks
3 tasks
MarshallOfSound
added a commit
that referenced
this pull request
Apr 4, 2022
This reverts commit 7c70136.
MarshallOfSound
added a commit
that referenced
this pull request
Apr 5, 2022
jkleinsc
pushed a commit
that referenced
this pull request
Apr 5, 2022
VerteDinde
pushed a commit
that referenced
this pull request
Apr 5, 2022
VerteDinde
pushed a commit
that referenced
this pull request
Apr 5, 2022
bavulapati
pushed a commit
to bavulapati/electron
that referenced
this pull request
Apr 29, 2022
…lectron#32692)" (electron#33599) This reverts commit 7c70136.
codebytere
pushed a commit
that referenced
this pull request
May 19, 2022
khalwa
pushed a commit
to solarwindscloud/electron
that referenced
this pull request
Feb 22, 2023
…lectron#32692)" (electron#33599) This reverts commit 7c70136.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #30760.
Fixes an issue where frameless windows would show chrome during the loading process when they shouldn't. Cleans up the logic for
SetWindowLongGWL_STYLEapplication to ensure thatWS_CAPTIONis removed when the window is frameless and not just whenthickFrameis false.Checklist
npm testpassesRelease Notes
Notes: Fixes an issue where frameless windows on Windows would incorrectly show a small frame during the loading process.