8000 fix: make windows without rounded corners closable by zcbenz · Pull Request #32597 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: make windows without rounded corners closable #32597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2022
Merged

fix: make windows without rounded corners closable #32597

merged 1 commit into from
Jan 25, 2022

Conversation

zcbenz
Copy link
Contributor
@zcbenz zcbenz commented Jan 24, 2022

Description of Change

Close #28686.

By default "Close Window" is always disabled when window has no title, this PR makes it possible to close such windows. This fixes the problem that windows with roundedCorners: false was not closable, because the option is implemented by removing window's title.

Also note that this PR removes the use of NSWindowStyleMaskFullSizeContentView style, it is actually no-op if the window has no title and we don't really need it to implement roundedCorners: false.

Release Notes

Notes: Fix windows with roundedCorners: false unable to be closed.

@zcbenz zcbenz added semver/patch backwards-compatible bug fixes target/15-x-y labels Jan 24, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jan 24, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jan 25, 2022
@jkleinsc jkleinsc merged commit 1cf3682 into main Jan 25, 2022
@jkleinsc jkleinsc deleted the close-window-without-title branch January 25, 2022 14:51
@release-clerk
Copy link
release-clerk bot commented Jan 25, 2022

Release Notes Persisted

Fix windows with roundedCorners: false unable to be closed.

This was referenced Jan 25, 2022
Merged
Merged
Merged
@trop
Copy link
Contributor
trop bot commented Jan 25, 2022

I have automatically backported this PR to "15-x-y", please check out #32610

@trop
Copy link
Contributor
trop bot commented Jan 25, 2022

I have automatically backported this PR to "16-x-y", please check out #32611

@trop
Copy link
Contributor
trop bot commented Jan 25, 2022

I have automatically backported this PR to "17-x-y", please check out #32612

t57ser pushed a commit to t57ser/electron that referenced this pull request Jan 25, 2022
@zcbenz @t57ser
fix: make window without rounded corners closable (electron#32597)
2cfe470
@trop trop bot removed the in-flight/15-x-y label Jan 26, 2022
@commit-lint commit-lint bot mentioned this pull request Mar 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: roundedCorners: false and frame: false make Electron unable to quit
3 participants
@zcbenz @nornagon @jkleinsc
0