docs: update context bridge docs about Promises and Errors #32533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From my testing it doesn't remove Promises in nested objects, also according to the test suite it does not: https://github.com/electron/electron/blob/80577a4f08824c031ad020b8f4e3c5975ff8081a/spec-main/api-context-bridge-spec.ts#L693
zcbenz
approved these changes
Jan 27, 2022
|
Release Notes Persisted
|
This was referenced Jan 27, 2022
trop bot
pushed a commit
that referenced
this pull request
Jan 27, 2022
* Update context bridge docs about Promises From my testing it doesn't remove Promises in nested objects, also according to the test suite it does not: https://github.com/electron/electron/blob/80577a4f08824c031ad020b8f4e3c5975ff8081a/spec-main/api-context-bridge-spec.ts#L693 * docs: Update docs for errors too
trop bot
pushed a commit
that referenced
this pull request
Jan 27, 2022
* Update context bridge docs about Promises From my testing it doesn't remove Promises in nested objects, also according to the test suite it does not: https://github.com/electron/electron/blob/80577a4f08824c031ad020b8f4e3c5975ff8081a/spec-main/api-context-bridge-spec.ts#L693 * docs: Update docs for errors too
|
I have automatically backported this PR to "17-x-y", please check out #32644 |
|
I have automatically backported this PR to "16-x-y", please check out #32645 |
|
I have automatically backported this PR to "15-x-y", please check out #32646 |
codebytere
pushed a commit
that referenced
this pull request
Jan 27, 2022
…32645) * Update context bridge docs about Promises From my testing it doesn't remove Promises in nested objects, also according to the test suite it does not: https://github.com/electron/electron/blob/80577a4f08824c031ad020b8f4e3c5975ff8081a/spec-main/api-context-bridge-spec.ts#L693 * docs: Update docs for errors too Co-authored-by: Mikael Finstad <finstaden@gmail.com>
zcbenz
pushed a commit
that referenced
this pull request
Jan 28, 2022
…32646) * Update context bridge docs about Promises From my testing it doesn't remove Promises in nested objects, also according to the test suite it does not: https://github.com/electron/electron/blob/80577a4f08824c031ad020b8f4e3c5975ff8081a/spec-main/api-context-bridge-spec.ts#L693 * docs: Update docs for errors too Co-authored-by: Mikael Finstad <finstaden@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
From my testing it doesn't remove Promises in nested objects,
also according to the test suite it does not:
electron/spec-main/api-context-bridge-spec.ts
Line 693 in 80577a4
Also improve Error description.
Checklist
npm testpassesRelease Notes
Notes: Updated context bridge docs about Promises and Errors.