8000 fix: undefined backgroundColor by codebytere · Pull Request #32517 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: undefined backgroundColor #32517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2022
Merged

fix: undefined backgroundColor #32517

merged 1 commit into from
Jan 19, 2022

Conversation

codebytere
Copy link
Member

Description of Change

Closes #32007.

Fixes an issue where if backgroundColor was set to undefined, vibrancy failed to work and the backgroundColor would show up as white. This was happening because we were converting the background color from an arbitrary v8::Value, when we only accept strings. As a result, undefined would return true from the conversion instead of false as it should. Fix this by expecting the more specific type.

Checklist

Release Notes

Notes: Fixed an issue where if backgroundColor was set to undefined, vibrancy failed to work and the backgroundColor would show up as white.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jan 18, 2022
@codebytere codebytere added semver/patch backwards-compatible bug fixes and removed new-pr 🌱 PR opened recently labels Jan 18, 2022
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jan 18, 2022
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jan 19, 2022
@jkleinsc jkleinsc merged commit df50a0e into main Jan 19, 2022
@jkleinsc jkleinsc deleted the fix-bg-color-undefined branch January 19, 2022 20:51
@release-clerk
Copy link
release-clerk bot commented Jan 19, 2022

Release Notes Persisted

Fixed an issue where if backgroundColor was set to undefined, vibrancy failed to work and the backgroundColor would show up as white.

@trop
Copy link
Contributor
trop bot commented Jan 19, 2022

I was unable to backport this PR to "16-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/16-x-y label Jan 19, 2022
@trop
Copy link
Contributor
trop bot commented Jan 19, 2022

I was unable to backport this PR to "17-x-y" cleanly;
you will need to perform this backport manually.

t57ser pushed a commit to t57ser/electron that referenced this pull request Jan 25, 2022
@codebytere @t57ser
fix: undefined backgroundColor (electron#32517)
5ef195b
@codebytere codebytere mentioned this pull request Jan 27, 2022
Merged
@trop
Copy link
Contributor
trop bot commented Jan 27, 2022

@codebytere has manually backported this PR to "17-x-y", please check out #32653

@codebytere codebytere mentioned this pull request Jan 27, 2022
Merged
@trop
Copy link
Contributor
trop bot commented Jan 27, 2022

@codebytere has manually backported this PR to "16-x-y", please check out #32654

@commit-lint commit-lint bot mentioned this pull request Mar 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@samuelmaddock samuelmaddock Awaiting requested review from samuelmaddock

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Vibrancy does not work if background color is set to undefined
4 participants
@codebytere @nornagon @jkleinsc @VerteDinde
0