8000 fix: correctly notify WebViewGuestDelegate when webview is detached by trop[bot] · Pull Request #31374 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: correctly notify WebViewGuestDelegate when webview is detached #31374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2021
Merged

fix: correctly notify WebViewGuestDelegate when webview is detached #31374

merged 1 commit into from
Oct 11, 2021

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Oct 11, 2021

Backport of #31350

See that PR for details.

Notes: Fix crash when changing zoom level for webview.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 11, 2021
@trop trop bot requested a review from zcbenz October 11, 2021 00:34
@trop trop bot mentioned this pull request Oct 11, 2021
Merged
@trop trop bot added 14-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Oct 11, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 11, 2021
@zcbenz zcbenz merged commit 7a3541d into 14-x-y Oct 11, 2021
@zcbenz zcbenz deleted the trop/14-x-y-bp-fix-correctly-notify-webviewguestdelegate-when-webview-is-detached-1633912429194 branch October 11, 2021 05:36
@release-clerk
Copy link
release-clerk bot commented Oct 11, 2021

Release Notes Persisted

Fix crash when changing zoom level for webview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
14-x-y backport This is a backport PR 4700 semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zcbenz
0