8000 fix: potential crash on missing render frame by codebytere · Pull Request #31289 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: potential crash on missing render frame #31289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2021
Merged

fix: potential crash on missing render frame #31289

merged 1 commit into from
Oct 7, 2021

Conversation

codebytere
Copy link
Member

Description of Change

Closes #31281.

Fixes an potential crash in WebContents::MessageTo when a render frame has been destroyed. Both other calls to GetRendererApi() are guarded by CheckRenderFrame(), and so this PR adds the same check to this third callsite.

Checklist

Release Notes

Notes: Fixes an potential crash in WebContents::MessageTo when a render frame has been destroyed.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/13-x-y labels Oct 5, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 5, 2021
@codebytere codebytere force-pushed the fix-render-frame-crash branch from 71628c4 to ed8ee5e Compare October 5, 2021 08:30
@codebytere codebytere force-pushed the fix-render-frame-crash branch from ed8ee5e to a4c56ad Compare October 5, 2021 08:30
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 6, 2021
@codebytere codebytere merged commit 9c8bd18 into main Oct 7, 2021
@codebytere codebytere deleted the fix-render-frame-crash branch October 7, 2021 05:26
@release-clerk
Copy link
release-clerk bot commented Oct 7, 2021

Release Notes Persisted

Fixes an potential crash in WebContents::MessageTo when a render frame has been destroyed.

This was referenced Oct 7, 2021
Merged
Merged
Merged
Merged
@trop
Copy link
Contributor
trop bot commented Oct 7, 2021

I have automatically backported this PR to "14-x-y", please check out #31333

@trop
Copy link
Contributor
trop bot commented Oct 7, 2021

I have automatically backported this PR to "15-x-y", please check out #31334

@trop
Copy link
Contributor
trop bot commented Oct 7, 2021

I have automatically backported this PR to "13-x-y", please check out #31335

@trop trop bot removed the target/15-x-y label Oct 7, 2021
@trop
Copy link
Contributor
trop bot commented Oct 7, 2021

I have automatically backported this PR to "16-x-y", please check out #31336

t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 27, 2021
@codebytere @t57ser
fix: crash on missing render frame (electron#31289)
033de3d
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 27, 2021
@codebytere @t57ser
fix: crash on missing render frame (electron#31289)
6921e0f
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 29, 2021
@codebytere @t57ser
fix: crash on missing render frame (electron#31289)
5a2ecca
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 29, 2021
@codebytere @t57ser
fix: crash on missing render frame (electron#31289)
41123b1
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 29, 2021
@codebytere @t57ser
fix: crash on missing render frame (electron#31289)
c56d359
t57ser pushed a commit to t57ser/electron that referenced this pull request Oct 29, 2021
@codebytere @t57ser
fix: crash on missing render frame (electron#31289)
8c4ee03
@commit-lint commit-lint bot mentioned this pull request Jan 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelmaddock samuelmaddock samuelmaddock approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Crash in electron::api::WebFrameMain::GetRendererApi
3 participants
@codebytere @samuelmaddock @VerteDinde
0