10000 fix: correct default text for button labels in gtk dialogs by trop[bot] · Pull Request #31823 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: correct default text for button labels in gtk dialogs #31823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 15, 2021
Merged

fix: correct default text for button labels in gtk dialogs #31823

merged 3 commits into from
Nov 15, 2021

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Nov 15, 2021

Backport of #31798

See that PR for details.

Notes: Fixed default label text in GTK dialogs.

ckerr added 3 commits November 15, 2021 07:18
@ckerr @electron-bot
fix: default label text on GTK dialogs
9d9d00d
< 8000 div class="d-flex flex-md-row flex-column">
@ckerr @electron-bot
refactor: make GtkGettext and GettextPackage private
add574b 
they do not need to be public to the rest of the codebase
@ckerr @electron-bot
fix: oops, meant to include this in previous commit
8424563
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Nov 15, 2021
@trop trop bot requested a review from ckerr November 15, 2021 07:19
@trop trop bot mentioned this pull request Nov 15, 2021
Merged
3 tasks
@trop trop bot added 15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Nov 15, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Nov 15, 2021
@codebytere codebytere merged commit 69014e7 into 15-x-y Nov 15, 2021
@codebytere codebytere deleted the trop/15-x-y-bp-fix-correct-default-text-for-button-labels-in-gtk-dialogs-1636960733192 branch November 15, 2021 15:19
@release-clerk
Copy link
release-clerk bot commented Nov 15, 2021

Release Notes Persisted

Fixed default label text in GTK dialogs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@ckerr ckerr Awaiting requested review from ckerr

Assignees
No one assigned
Labels
15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @ckerr
0