fix: in GTK open dialog, do not preview huge files #31799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previewing images whose files are larger than a GB can crash Electron.
codebytere
approved these changes
Nov 11, 2021
shell/browser/ui/file_dialog_gtk.cc
Outdated
| // Setting an arbitrary filesize max t at 100 MB here. | ||
| constexpr off_t ArbitraryMax = 100000000ULL; | ||
| if (st.st_size >= ArbitraryMax) { | ||
| return false; |
There was a problem hiding this comment.
tiny nit but we can probably just
return st.st_size < ArbitraryMax;
here!
zcbenz
approved these changes
Nov 14, 2021
|
Release Notes Persisted
|
This was referenced Nov 15, 2021
|
I have automatically backported this PR to "14-x-y", please check out #31819 |
|
I have automatically backported this PR to "15-x-y", please check out #31820 |
|
I have automatically backported this PR to "16-x-y", please check out #31821 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #31630.
Adds a size check to the image file before previewing it. I've set the cutoff at 100 MB since "100 MB ought to be enough for anybody" but if there's a strong use case for previewing 100 MB image files we could increase it.
CC @codebytere
Checklist
npm testpassesRelease Notes
Notes: Fixed crash in GTK open dialog when trying to preview huge image files.