10000 fix: crash on close window when webContents destroyed by codebytere · Pull Request #31620 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: crash on close window when webContents destroyed #31620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2021
Merged

fix: crash on close window when webContents destroyed #31620

merged 1 commit into from
Nov 1, 2021

Conversation

codebytere
Copy link
Member

Description of Change

Closes #31337.

Fixes a crash when a BrowserWindow is closed subsequent to its webContents being destroyed.

We were checking for web_contents() being nullptr but not api_web_contents_, which would be the case if the webContents is destroyed prior to the window.

Checklist

Release Notes

Notes: Fixed a crash when a BrowserWindow is closed subsequent to its webContents being destroyed.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/14-x-y labels Oct 28, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 28, 2021
@codebytere codebytere mentioned this pull request Oct 28, 2021
Closed
3 tasks
@codebytere codebytere changed the title fix: crash on close window when WC destroyed fix: crash on close window when webContents destroyed Oct 28, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 29, 2021
@zcbenz zcbenz merged commit 20b4813 into main Nov 1, 2021
@zcbenz zcbenz deleted the fix-close-crash branch November 1, 2021 04:32
@release-clerk
Copy link
release-clerk bot commented Nov 1, 2021

Release Notes Persisted

Fixed a crash when a BrowserWindow is closed subsequent to its webContents being destroyed.

This was referenced Nov 1, 2021
Merged
Merged
Merged
@trop
Copy link
Contributor
trop bot commented Nov 1, 2021

I have automatically backported this PR to "15-x-y", please check out #31644

@trop
Copy link
Contributor
trop bot commented Nov 1, 2021

I have automatically backported this PR to "14-x-y", please check out #31645

@trop
Copy link
Contributor
trop bot commented Nov 1, 2021

I have automatically backported this PR to "16-x-y", please check out #31646

@trop trop bot added merged/16-x-y and removed target/16-x-y labels Nov 1, 2021
t57ser pushed a commit to t57ser/electron that referenced this pull request Jan 25, 2022
@codebytere @t57ser
fix: crash on close window when webContents destroyed (electron#31620)
deed000
@commit-lint commit-lint bot mentioned this pull request Feb 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Crash when closing a window which has its webcontents destroyed
4 participants
@codebytere @zcbenz @VerteDinde @MarshallOfSound
0