8000 fix: don't use private enterprise APIs in MAS build by VerteDinde · Pull Request #31483 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: don't use private enterprise APIs in MAS build #31483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2021
Merged

fix: don't use private enterprise APIs in MAS build #31483

merged 1 commit into from
Oct 20, 2021

Conversation

VerteDinde
Copy link
Member

Description of Change

Manual backport of #31482

See that PR for details.

Notes: Removes several Chromium private APIs from Mac Apple Store builds.

@VerteDinde VerteDinde added the semver/patch backwards-compatible bug fixes label Oct 20, 2021
@VerteDinde VerteDinde requested a review from a team as a code owner October 20, 2021 01:05
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 20, 2021
@trop trop bot removed the semver/patch backwards-compatible bug fixes label Oct 20, 2021
@trop trop bot mentioned this pull request Oct 20, 2021
Merged
5 tasks
@trop trop bot added 15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Oct 20, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 20, 2021
@VerteDinde VerteDinde force-pushed the 15-x-y-gate-enteprise-APIs-in-MAS-builds branch from eb71591 to 1f4dc65 Compare October 20, 2021 01:57
@VerteDinde VerteDinde force-pushed the 15-x-y-gate-enteprise-APIs-in-MAS-builds branch from 1f4dc65 to 4d5fa54 Compare October 20, 2021 02:25
@MarshallOfSound MarshallOfSound merged commit 5e815df into 15-x-y Oct 20, 2021
@MarshallOfSound MarshallOfSound deleted the 15-x-y-gate-enteprise-APIs-in-MAS-builds branch October 20, 2021 06:14
@release-clerk
Copy link
release-clerk bot commented Oct 20, 2021

Release Notes Persisted

Removes several Chromium private APIs from Mac Apple Store builds.

KishanBagaria pushed a commit to KishanBagaria/electron that referenced this pull request Oct 20, 2021
@VerteDinde @KishanBagaria
fix: don't use private enterprise APIs in MAS build (electron#31483)
75e865a
@kalbroni7 kalbroni7 mentioned this pull request Jul 15, 2024
Open
@Mjr8816 Mjr8816 mentioned this pull request Sep 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VerteDinde @MarshallOfSound
0