8000 fix: console window popping up when --enable-logging passed on windows by trop[bot] · Pull Request #30386 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: console window popping up when --enable-logging passed on windows #30386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 4, 2021
Merged

fix: console window popping up when --enable-logging passed on windows #30386

merged 3 commits into from
Aug 4, 2021

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Aug 3, 2021

Backport of #30375

See that PR for details.

Notes: Fixed an issue on Windows where empty console windows were appearing when --enable-logging was present.

@trop trop bot requested a review from a team as a code owner August 3, 2021 21:09
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Aug 3, 2021
@trop trop bot requested a review from nornagon August 3, 2021 21:09
@trop trop bot mentioned this pull request Aug 3, 2021
Merged
2 tasks
@trop trop bot added 15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Aug 3, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Aug 3, 2021
@zcbenz zcbenz merged commit 73b280d into 15-x-y Aug 4, 2021
@zcbenz zcbenz deleted the trop/15-x-y-bp-fix-console-window-popping-up-when-enable-logging-passed-on-windows-1628024954654 branch August 4, 2021 23:58
@release-clerk
Copy link
release-clerk bot commented Aug 4, 2021

Release Notes Persisted

Fixed an issue on Windows where empty console windows were appearing when --enable-logging was present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nornagon @zcbenz
0