8000 fix: use `contentAspectRatio` in `setAspectRatio()` on macOS by trop[bot] · Pull Request #30332 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: use contentAspectRatio in setAspectRatio() on macOS #30332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2021
Merged

fix: use contentAspectRatio in setAspectRatio() on macOS #30332

merged 1 commit into from
Jul 30, 2021

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Jul 29, 2021

Backport of #30305

See that PR for details.

Notes: Fixes an issue where a specified aspect ratio could become incorrect when maximizing a window on macOS.

@trop trop bot requested a review from codebytere July 29, 2021 21:28
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 29, 2021
@trop trop bot mentioned this pull request Jul 29, 2021
Merged
3 tasks
@trop trop bot added 15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 29, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 29, 2021
@MarshallOfSound MarshallOfSound merged commit 0cd714a into 15-x-y Jul 30, 2021
@MarshallOfSound MarshallOfSound deleted the trop/15-x-y-bp-fix-use-contentaspectratio-in-setaspectratio-on-macos-1627594105532 branch July 30, 2021 09:24
@release-clerk
Copy link
release-clerk bot commented Jul 30, 2021

Release Notes Persisted

Fixes an issue where a specified aspect ratio could become incorrect when maximizing a window on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@codebytere codebytere Awaiting requested review from codebytere

Assignees
No one assigned
Labels
15-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarshallOfSound @codebytere
0