8000 fix: update traffic lights position for macOS 11 by zcbenz · Pull Request #30263 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: update traffic lights position for macOS 11 #30263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2021
Merged

fix: update traffic lights position for macOS 11 #30263

merged 1 commit into from
Jul 26, 2021

Conversation

zcbenz
Copy link
Contributor
@zcbenz zcbenz commented Jul 26, 2021

Description of Change

Close #30230.

Since macOS 11 the default position of traffic lights has changed, but #27489 did not take account of it. This PR updates the position of traffic lights for titleBarStyle: 'hidden', so the behavior matches Electron <= 12.

Release Notes

Notes: Fix frameless window having wrong traffic lights position on macOS 11.

@zcbenz zcbenz added semver/patch backwards-compatible bug fixes target/13-x-y labels Jul 26, 2021
@zcbenz zcbenz requested a review from deepak1556 July 26, 2021 12:03
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 26, 2021
@deepak1556
Copy link
Member

Failing tests are unrelated, merging.

@deepak1556 deepak1556 merged commit d2989de into main Jul 26, 2021
@deepak1556 deepak1556 deleted the fix-traffic-light-position branch July 26, 2021 16:22
@release-clerk
Copy link
release-clerk bot commented Jul 26, 2021

Release Notes Persisted

Fix frameless window having wrong traffic lights position on macOS 11.

@trop
Copy link
Contributor
trop bot commented Jul 26, 2021

I was unable to backport this PR to "13-x-y" cleanly;
you will need to perform this backport manually.

This was referenced Jul 26, 2021
Merged
Merged
@trop
Copy link
Contributor
trop bot commented Jul 26, 2021

I have automatically backported this PR to "14-x-y", please check out #30269

@trop
Copy link
Contributor
trop bot commented Jul 26, 2021

I have automatically backported this PR to "15-x-y", please check out #30270

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 28, 2021
deepak1556 pushed a commit that referenced this pull request Jul 29, 2021
@zcbenz @deepak1556
fix: update traffic lights position for macOS 11 (#30263)
4dabf92
@deepak1556 deepak1556 mentioned this pull request Jul 29, 2021
Merged
@trop
Copy link
Contributor
trop bot commented Jul 29, 2021

@deepak1556 has manually backported this PR to "13-x-y", please check out #30319

georgexu99 pushed a commit to georgexu99/electron that referenced this pull request Jul 29, 2021
@zcbenz
fix: update traffic lights position for macOS 11 (electron#30263)
f2e85c0
BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
@zcbenz @BlackHole1
fix: update traffic lights position for macOS 11 (electron#30263)
ec33584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: incorrect position of traffic lights with custom titlebar
3 participants
@zcbenz @deepak1556 @codebytere
0