chore: cherry-pick fix for 1230767 from chromium #30638
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protect candidate better from garbage collection during negotiation.
Includes a test that was reliably observed to produce an UAF on Linux
when compiled with ASAN before the fix.
Bug: chromium:1230767
Change-Id: I02dd29332a6d00790dcace41b6584b96413ef6f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3057049
Reviewed-by: Florent Castelli orphis@chromium.org
Commit-Queue: Harald Alvestrand hta@chromium.org
[modify] https://crrev.com/654536e793760b23679131e9f8db45620e5636c7/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection_handler.cc
[add] https://crrev.com/654536e793760b23679131e9f8db45620e5636c7/third_party/blink/web_tests/fast/peerconnection/poc-123067.html
Notes: Security: Backported fix for 1230767.