10000 chore: cherry-pick fix for 1230767 from chromium by zcbenz · Pull Request #30638 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: cherry-pick fix for 1230767 from chromium #30638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Conversation

zcbenz
Copy link
Contributor
@zcbenz zcbenz commented Aug 19, 2021

Protect candidate better from garbage collection during negotiation.

Includes a test that was reliably observed to produce an UAF on Linux
when compiled with ASAN before the fix.

Bug: chromium:1230767
Change-Id: I02dd29332a6d00790dcace41b6584b96413ef6f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3057049
Reviewed-by: Florent Castelli orphis@chromium.org
Commit-Queue: Harald Alvestrand hta@chromium.org

[modify] https://crrev.com/654536e793760b23679131e9f8db45620e5636c7/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection_handler.cc
[add] https://crrev.com/654536e793760b23679131e9f8db45620e5636c7/third_party/blink/web_tests/fast/peerconnection/poc-123067.html

Notes: Security: Backported fix for 1230767.

@zcbenz zcbenz added semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking target/11-x-y labels Aug 19, 2021
@zcbenz zcbenz requested a review from a team as a code owner August 19, 2021 06:37
@zcbenz zcbenz merged commit a3e4719 into 13-x-y Sep 1, 2021
@zcbenz zcbenz deleted the cherry-pick-1230767 branch September 1, 2021 11:50
@release-clerk
Copy link
release-clerk bot commented Sep 1, 2021

Release Notes Persisted

Security: Backported fix for 1230767.

trop bot pushed a commit that referenced this pull request Sep 1, 2021
* chore: cherry-pick fix for 1230767 from chromium

* chore: update patches

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
trop bot pushed a commit that referenced this pull request Sep 1, 2021
* chore: cherry-pick fix for 1230767 from chromium

* chore: update patches

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
@trop
Copy link
Contributor
trop bot commented Sep 1, 2021

I have automatically backported this PR to "11-x-y", please check out #30791

@trop
Copy link
Contributor
trop bot commented Sep 1, 2021

I have automatically backported this PR to "12-x-y", please check out #30792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0