8000 fix: ensure web_contents() is alive before grabbing view by MarshallOfSound · Pull Request #30571 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: ensure web_contents() is alive before grabbing view #30571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2021
Merged

fix: ensure web_contents() is alive before grabbing view #30571

merged 1 commit into from
Aug 17, 2021

Conversation

MarshallOfSound
Copy link
Member

Notes: Fixed potential crash when programatically closing a draggable frameless child window

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Aug 17, 2021
@MarshallOfSound MarshallOfSound added fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases semver/patch backwards-compatible bug fixes target/14-x-y labels Aug 17, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Aug 17, 2021
@VerteDinde VerteDinde mentioned this pull request Aug 17, 2021
Merged
@MarshallOfSound MarshallOfSound merged commit b62bbfd into main Aug 17, 2021
@MarshallOfSound MarshallOfSound deleted the protect-wc branch August 17, 2021 21:00
@release-clerk
Copy link
release-clerk bot commented Aug 17, 2021

Release Notes Persisted

Fixed potential crash when programatically closing a draggable frameless child window

@trop
Copy link
Contributor
trop bot commented Aug 17, 2021

I was unable to backport this PR to "14-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/14-x-y label Aug 17, 2021
@trop
Copy link
Contributor
trop bot commented Aug 17, 2021

I was unable to backport this PR to "15-x-y" cleanly;
you will need to perform this backport manually.

miniak pushed a commit that referenced this pull request Aug 18, 2021
@MarshallOfSound @miniak
fix: ensure web_contents() is alive before grabbing view (#30571)
218bd3d
BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
@MarshallOfSound @BlackHole1
fix: ensure web_contents() is alive before grabbing view (electron#30571
627373e 
)
@VerteDinde VerteDinde mentioned this pull request Sep 20, 2021
Merged
@trop
Copy link
Contributor
trop bot commented Sep 20, 2021

@VerteDinde has manually backported this PR to "15-x-y", please check out #31027

@VerteDinde VerteDinde mentioned this pull request Sep 29, 2021
Merged
@trop
Copy link
Contributor
trop bot commented Sep 29, 2021

@VerteDinde has manually backported this PR to "14-x-y", please check out #31187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees
No one assigned
Labels
fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarshallOfSound @VerteDinde
0