8000 fix: mouse doesn't work on frameless browserwindows by ckerr · Pull Request #30447 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: mouse doesn't work on frameless browserwindows #30447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2021
Merged

fix: mouse doesn't work on frameless browserwindows #30447

merged 1 commit into from
Aug 10, 2021

Conversation

ckerr
Copy link
Member
@ckerr ckerr commented Aug 8, 2021 •
edited
Loading

Description of Change

Fixes #30402. This the issue that @electron/wg-releases marked as a stable blocker last week.

This bug is from the "CanResize has been de-virtualized" refactor in #29256

One-sentence summary: In order for CanResize() to return the right value here, we need to call SetCanResize() first.

Checklist

Release Notes

Notes: Fix beta-only bug that caused mouse clicks to not be processed in frameless windows.

@ckerr
fix: mouse doesn't work on frameless browserwindows
00853d0 
Fixes #30402. This bug is from the "CanResize has been de-virtualized"
refactor in #29256
@ckerr ckerr requested a review from a team August 8, 2021 15:00
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Aug 8, 2021
@ckerr ckerr mentioned this pull request Aug 8, 2021
Closed
3 tasks
@zcbenz zcbenz added the semver/patch backwards-compatible bug fixes label Aug 9, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Aug 9, 2021
@zcbenz zcbenz merged commit edb7413 into main Aug 10, 2021
@zcbenz zcbenz deleted the fix/30402-mouse-doesnt-work-for-frameless-browserwindows branch August 10, 2021 01:01
@release-clerk
Copy link
release-clerk bot commented Aug 10, 2021

Release Notes Persisted

Fix beta-only bug that caused mouse clicks to not be processed in frameless windows.

This was referenced Aug 10, 2021
Merged
Merged
@trop
Copy link
Contributor
trop bot commented Aug 10, 2021

I have automatically backported this PR to "14-x-y", please check out #30459

@trop
Copy link
Contributor
trop bot commented Aug 10, 2021

I have automatically backported this PR to "15-x-y", please check out #30460

BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
@ckerr @BlackHole1
fix: mouse doesn't work on frameless browserwindows (electron#30447)
ee315f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Mouse doesn't work for frameless browserwindows
3 participants
@ckerr @zcbenz @MarshallOfSound
0