8000 feat: add support for Blob's going over the ctx bridge by MarshallOfSound · Pull Request #29247 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add support for Blob's going over the ctx bridge #29247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2021
Merged

feat: add support for Blob's going over the ctx bridge #29247

merged 1 commit into from
May 26, 2021

Conversation

MarshallOfSound
Copy link
Member

Based on #26776 and fixes #27364

Notes: Added support for sending Blobs over the context bridge.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label May 19, 2021
@MarshallOfSound MarshallOfSound added no-backport semver/minor backwards-compatible functionality labels May 19, 2021
zcbenz
zcbenz approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor
@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API looks good to me.

@MarshallOfSound MarshallOfSound merged commit f01e35f into master May 26, 2021
@release-clerk
Copy link
release-clerk bot commented May 26, 2021

Release Notes Persisted

Added support for sending Blobs over the context bridge.

@MarshallOfSound MarshallOfSound deleted the blob-ctx-bridge branch May 26, 2021 17:34
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
api-review/requested 🗳 new-pr 🌱 PR opened recently no-backport semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blob is empty if it is passed as a parameter via contextBridge
3 participants
@MarshallOfSound @nornagon @zcbenz
0