8000 fix: window ordering on mac by deepak1556 · Pull Request #29857 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: window ordering on mac #29857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2021
Merged

fix: window ordering on mac #29857

merged 1 commit into from
Jul 9, 2021

Conversation

deepak1556
Copy link
Member
@deepak1556 deepak1556 commented Jun 23, 2021 •
edited
Loading

Description of Change

Fixes #29758

The call to NativeWidgetMac::Activate added in #29204 tries to set the visibility state of the window via NativeWidgetNSWindowBridge with state kShowAndActivateWindow which eventually calls [NSWindow makeKeyAndOrderFront:]

This is all fine for normal cases, but under the following situations it triggers a series of windowDidBecomeKey: notifications that messes with window ordering.

  1. When opening panels the main window takes key status and captures the input events
  2. When in fullscreen opening a second window does not inherit the fullscreen behavior
  3. Custom window switchers are unable to switch between windows

Since we are making the widget call in the key window notification code path, it is safe to remove this redundant call that is causing the above incorrect behaviors.

Checklist

Release Notes

Notes: fix key window status on mac when opening panels or using custom window switchers

@deepak1556 deepak1556 force-pushed the robo/fix_mac_focus branch from fea7b82 to 6cc7ccd Compare June 23, 2021 08:00
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jun 23, 2021
@deepak1556 deepak1556 added semver/patch backwards-compatible bug fixes target/12-x-y labels Jun 23, 2021
@deepak1556 deepak1556 force-pushed the robo/fix_mac_focus branch from 6cc7ccd to 3274104 Compare June 23, 2021 08:03
nornagon
nornagon reviewed Jun 23, 2021
View reviewed changes
spec-main/api-browser-window-spec.ts
const w2 = new BrowserWindow();
await delay();
expect(w2.isFullScreen()).to.be.true('isFullScreen');
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add more tests for the other behaviors you mentioned?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find a good way to automate tests for scenarios 1 and 3. Scenario 1) requires to check that the Quick Panel from the OS receives the input event and Scenario 3) requires a custom window switcher like https://alt-tab-macos.netlify.app/ for example.

@nornagon
Copy link
Contributor

Is this possibly related? #28348

@deepak1556
Copy link
Member Author

Is this possibly related? #28348

Nope it is unrelated.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jun 24, 2021
@deepak1556 deepak1556 requested a review from nornagon July 1, 2021 03:29
@deepak1556
fix: window ordering on mac
< 8000 input type="hidden" name="oid" value="fc156835299c4bc531b8a92d35d265c8a3bb0210" autocomplete="off" data-targets="batch-deferred-content.inputs" />
fc15683
@deepak1556 deepak1556 force-pushed the robo/fix_mac_focus branch from 3274104 to fc15683 Compare July 1, 2021 05:23
@deepak1556
Copy link
Member Author

Failing tests are unrelated, merging.

@deepak1556 deepak1556 merged commit ccfde6c into main Jul 9, 2021
@deepak1556 deepak1556 deleted the robo/fix_mac_focus branch July 9, 2021 20:38
@release-clerk
Copy link
release-clerk bot commented Jul 9, 2021

Release Notes Persisted

fix key window status on mac when opening panels or using custom window switchers

This was referenced Jul 9, 2021
Merged
Merged
@trop
Copy link
Contributor
trop bot commented Jul 9, 2021

I have automatically backported this PR to "14-x-y", please check out #30066

@trop
Copy link
Contributor
trop bot commented Jul 9, 2021

I have automatically backported this PR to "12-x-y", please check out #30067

@miniak
Copy link
Contributor
miniak commented Jul 9, 2021

/trop run backport-to 13-x-y

@trop
Copy link
Contributor
trop bot commented Jul 9, 2021

The backport process for this PR has been manually initiated - sending your PR to 13-x-y!

@trop
Copy link
Contributor
trop bot commented Jul 9, 2021

I was unable to backport this PR to "13-x-y" cleanly;
you will need to perform this backport manually.

@deepak1556 deepak1556 mentioned this pull request Jul 12, 2021
Merged
@deepak1556 deepak1556 mentioned this pull request Jul 13, 2021
Merged
@lenny-optiopay lenny-optiopay mentioned this pull request Jul 26, 2021
Closed
BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
@deepak1556 @BlackHole1
fix: window ordering on mac (electron#29857)
c60b74b
@codebytere
Copy link
Member

Backported in #29234 - missed owing to bad syntax for backport pr body

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

@codebytere codebytere Awaiting requested review from codebytere

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: App hijacks focus from win.previewFile since v12.0.9
5 participants
@deepak1556 @nornagon @miniak @codebytere @zcbenz
0