8000 fix: change ASAR archive cache to per-process to fix leak by trop[bot] · Pull Request #29535 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: change ASAR archive cache to per-process to fix leak #29535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 4, 2021
Merged

fix: change ASAR archive cache to per-process to fix leak #29535

merged 5 commits into from
Jun 4, 2021

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Jun 4, 2021

Backport of #29293

See that PR for details.

Notes: Fixed memory leak when requesting files in ASAR archive from renderer

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jun 4, 2021
@trop trop bot mentioned this pull request Jun 4, 2021
Merged
3 tasks
@trop trop bot added 13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jun 4, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jun 4, 2021
@zcbenz zcbenz merged commit ff2a0a4 into 13-x-y Jun 4, 2021
@zcbenz zcbenz deleted the trop/13-x-y-bp-fix-change-asar-archive-cache-to-per-process-to-fix-leak-1622771363718 branch June 4, 2021 04:19
@release-clerk
Copy link
release-clerk bot commented Jun 4, 2021

Release Notes Persisted

Fixed memory leak when requesting files in ASAR archive from renderer

MarshallOfSound added a commit that referenced this pull request Jun 4, 2021
@MarshallOfSound
Revert "fix: change ASAR archive cache to per-process to fix leak (#2…
0dcc660 
…9535)"

This reverts commit ff2a0a4.
MarshallOfSound added a commit that referenced this pull request Jun 4, 2021
@MarshallOfSound
Revert "Revert "fix: change ASAR archive cache to per-process to fix …
314e627 
…leak (#29535)""

This reverts commit 0dcc660.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zcbenz @dsanders11
0