8000 fix: window.print() in pdf plugin by trop[bot] · Pull Request #28351 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: window.print() in pdf plugin #28351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2021
Merged

fix: window.print() in pdf plugin #28351

merged 1 commit into from
Mar 24, 2021

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Mar 23, 2021

Backport of #28328

See that PR for details.

Notes: Fixed an issue where window.print() did not work properly when printing a pdf from the pdf plugin.

@electron-cation electron-cation bot added the 8000 new-pr 🌱 PR opened recently label Mar 23, 2021
@trop trop bot requested a review from codebytere March 23, 2021 14:41
@trop trop bot mentioned this pull request Mar 23, 2021
Merged
3 tasks
@trop trop bot added 13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 23, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 23, 2021
@zcbenz
Copy link
Contributor
zcbenz commented Mar 24, 2021

The CI failures are not related to this PR.

@zcbenz zcbenz merged commit 38de02c into 13-x-y Mar 24, 2021
@release-clerk
Copy link
release-clerk bot commented Mar 24, 2021

Release Notes Persisted

Fixed an issue where window.print() did not work properly when printing a pdf from the pdf plugin.
< 8371 form class="js-comment-update" id="issuecomment-805392165-edit-form" data-turbo="false" action="/electron/electron/issue_comments/805392165" accept-charset="UTF-8" method="post">

@trop trop bot deleted the trop/13-x-y-bp-fix-window-print-in-pdf-plugin-1616510456134 branch March 24, 2021 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zcbenz @codebytere
0