8000 fix: escape URL passed to shell.openExternal on windows by trop[bot] · Pull Request #28339 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: escape URL passed to shell.openExternal on windows #28339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2021
Merged

fix: escape URL passed to shell.openExternal on windows #28339

merged 1 commit into from
Mar 23, 2021

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Mar 22, 2021

Backport of #28334

See that PR for details.

Notes: URLS passed to shell.openExternal on windows are now correctly URI encoded. This was already occurring on macOS and Linux.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 22, 2021
@trop trop bot requested a review from MarshallOfSound March 22, 2021 23:33
@trop trop bot mentioned this pull request Mar 22, 2021
Merged
@trop trop bot added 10-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 22, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 22, 2021
@codebytere
Copy link
Member

Error unrelated.

@codebytere codebytere merged commit 93b4483 into 10-x-y Mar 23, 2021
@release-clerk
Copy link
release-clerk bot commented Mar 23, 2021

Release Notes Persisted

URLS passed to shell.openExternal on windows are now correctly URI encoded. This was already occurring on macOS and Linux.

@trop trop bot deleted the trop/10-x-y-bp-fix-escape-url-passed-to-shell-openexternal-on-windows-1616456009269 branch March 23, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
10-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @MarshallOfSound
0