8000 feat: allow omitting submitURL when uploadToServer is false by trop[bot] · Pull Request #28283 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: allow omitting submitURL when uploadToServer is false #28283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 24, 2021
Merged

feat: allow omitting submitURL when uploadToServer is false #28283

merged 3 commits into from
Mar 24, 2021

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Mar 18, 2021

Backport of #28105

See that PR for details.

Notes: The submitURL option for crashReporter.start is no longer a required argument when uploadToServer is false.

@trop trop bot requested a review from nornagon March 18, 2021 21:53
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 18, 2021
@trop trop bot mentioned this pull request Mar 18, 2021
Merged
5 tasks
@trop trop bot added 13-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Mar 18, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 18, 2021
@jkleinsc
Copy link
Member

This was approved for backport at the March 24, 2021 releases meeting.

@jkleinsc jkleinsc merged commit 831bbc4 into 13-x-y Mar 24, 2021
@release-clerk
Copy link
release-clerk bot commented Mar 24, 2021

Release Notes Persisted

The submitURL option for crashReporter.start is no longer a required argument when uploadToServer is false.

@trop trop bot deleted the trop/13-x-y-bp-feat-allow-omitting-submiturl-when-uploadtoserver-is-false-1616104395843 branch March 24, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
13-x-y backport/approved ✅ backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkleinsc @nornagon
0