8000 fix: libuv hang on Windows by codebytere · Pull Request #28175 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: libuv hang on Windows #28175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2021
Merged

fix: libuv hang on Windows #28175

merged 2 commits into from
Mar 22, 2021

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented Mar 13, 2021 •
edited
Loading

Description of Change

Closes #28154.

#25869 used uv_loop_->iocp to decide whether to re-prep the message loop, and it turns out not to be the case that it works and updates the same way that uv_backend_fd does, so what resulted was that when allowRendererProcessReuse was true the loop would not re-prep on reload and libuv would hang.

This fixes that by only handling this case on non-Windows systems.

Tested with https://gist.github.com/codebytere/2face1c26d09e38c06f49111c3fca13f.

Checklist

Release Notes

Notes: Fixed an issue where some Node.js modules would hang on page reload on Windows.

@codebytere codebytere requested review from zcbenz and deepak1556 March 13, 2021 14:38
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 13, 2021
@codebytere codebytere requested a review from nornagon March 13, 2021 14:40
@codebytere codebytere added the semver/patch backwards-compatible bug fixes label Mar 13, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 14, 2021
MarshallOfSound
MarshallOfSound reviewed Mar 15, 2021
View reviewed changes
Copy link
Member
@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way we can test for this?

@codebytere
Copy link
Member Author

@MarshallOfSound i'll see what i can do 🤔

@codebytere codebytere force-pushed the fix-libuv-hang branch 6 times, most recently from c640620 to d7327d0 Compare March 22, 2021 15:06
@codebytere
Copy link
Member Author

Asan test failures are unrelated - merging.

@codebytere codebytere merged commit 665ac6f into master Mar 22, 2021
@release-clerk
Copy link
release-clerk bot commented Mar 22, 2021

Release Notes Persisted

Fixed an issue where some Node.js modules would hang on page reload on Windows.

@codebytere codebytere deleted the fix-libuv-hang branch March 22, 2021 20:11
@trop trop bot mentioned this pull request Mar 22, 2021
Merged
@trop
Copy link
Contributor
trop bot commented Mar 22, 2021

I have automatically backported this PR to "13-x-y", please check out #28335

This was referenced Mar 22, 2021
Merged
Merged
@trop
Copy link
Contributor
trop bot commented Mar 22, 2021

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/10-x-y label Mar 22, 2021
@trop
Copy link
Contributor
trop bot commented Mar 22, 2021

I have automatically backported this PR to "11-x-y", please check out #28336

@trop
Copy link
Contributor
trop bot commented Mar 22, 2021

I have automatically backported this PR to "12-x-y", please check out #28337

@deepak1556 deepak1556 mentioned this pull request Apr 9, 2021
Closed
@rzhao271 rzhao271 mentioned this pull request Apr 15, 2021
Merged
@deepak1556 deepak1556 mentioned this pull request Mar 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

@deepak1556 deepak1556 Awaiting requested review from deepak1556

@nornagon nornagon Awaiting requested review from nornagon

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Renderer Promise API stops working after page reload when allowRendererProcessReuse is true
3 participants
@codebytere @jkleinsc @MarshallOfSound
0