10000 fix: convert system colors to device color space in systemPreferences by trop[bot] · Pull Request #28173 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: convert system colors to device color space in systemPreferences #28173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2021
Merged

fix: convert system colors to device color space in systemPreferences #28173

merged 1 commit into from
Mar 13, 2021

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Mar 13, 2021

Backport of #28121

See that PR for details.

Notes: Colors returned from systemPreferences.getAccentColor(), getSystemColor and getColor are now correctly converted into the devices color space. Previously the color would have been subtly incorrect.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 13, 2021
@trop trop bot requested a review from MarshallOfSound March 13, 2021 07:31
@trop trop bot mentioned this pull request Mar 13, 2021
Merged
@trop trop bot added 13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 13, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 13, 2021
@codebytere
Copy link
Member

Asan test failure not relevant.

@codebytere codebytere merged commit 7f4ab06 into 13-x-y Mar 13, 2021
@release-clerk
Copy link
release-clerk bot commented Mar 13, 2021

Release Notes Persisted

Colors returned from systemPreferences.getAccentColor(), getSystemColor and getColor are now correctly converted into the devices color space. Previously the color would have been subtly incorrect.

@codebytere codebytere 6E8F deleted the trop/13-x-y-bp-fix-convert-system-colors-to-device-color-space-in-systempreferences-1615620688614 branch March 13, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @MarshallOfSound
0