8000 fix: values return from the ctx bridge with dynamic property support should themselves support dynamic properties by VerteDinde · Pull Request #28160 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: values return from the ctx bridge with dynamic property support should themselves support dynamic properties #28160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2021
Merged

fix: values return from the ctx bridge with dynamic property support should themselves support dynamic properties #28160

merged 1 commit into from
Mar 13, 2021

Conversation

VerteDinde
Copy link
Member

Manual backport of #27899 (cc @MarshallOfSound)

See that PR for details.

Notes: Fixed issue where window.open() would not return an object with a location.href setter when contextIsolation is enabled and nativeWindowOpen is disabled.

@VerteDinde VerteDinde added backport This is a backport PR 10-x-y labels Mar 12, 2021
@trop trop bot mentioned this pull request Mar 12, 2021
Merged
@trop trop bot added the semver/patch backwards-compatible bug fixes label Mar 12, 2021
@codebytere codebytere merged commit 12a9970 into 10-x-y Mar 13, 2021
@release-clerk
Copy link
release-clerk bot commented Mar 13, 2021

Release Notes Persisted

Fixed issue where window.open() would not return an object with a location.href setter when contextIsolation is enabled and nativeWindowOpen is disabled.

@codebytere codebytere deleted the 10-x-y-dynamic-dynamic branch March 13, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
10-x-y backport This is a backport PR 49EB semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VerteDinde @MarshallOfSound @codebytere
0