8000 fix: end attached sheet when calling window.hide() by codebytere · Pull Request #28671 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: end attached sheet when calling window.hide() #28671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2021
Merged

fix: end attached sheet when calling window.hide() #28671

merged 1 commit into from
Apr 16, 2021

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented Apr 15, 2021 •
edited
Loading

Description of Change

Closes #28658.

If a sheet is attached to the window when we call [window_ orderOut:nil] in window.hide() on macOS, the sheet won't be able to show again on the same window. We therefore should be closing the attached sheet before calling [window_ orderOut:nil] on the NSWindow being hidden.

Tested with https://github.com/tsminh/electron-dialog-missing-after-hide

Checklist

Release Notes

Notes: Fixed an issue where some dialogs would stop working on macOS if window.hide() was called while they were open.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/10-x-y labels Apr 15, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 15, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Apr 16, 2021
@codebytere codebytere merged commit 484931b into master Apr 16, 2021
@codebytere codebytere deleted the dialog-disappearing-act branch April 16, 2021 15:42
@release-clerk
Copy link
release-clerk bot commented Apr 16, 2021

Release Notes Persisted

Fixed an issue where some dialogs would stop working on macOS if window.hide() was called while they were open.

This was referenced Apr 16, 2021
Merged
Merged
Merged
@trop
Copy link
Contributor
trop bot commented Apr 16, 2021

I have automatically backported this PR to "13-x-y", please check out #28694

@trop
Copy link
Contributor
trop bot commented Apr 16, 2021

I have automatically backported this PR to "12-x-y", please check out #28695

@trop
Copy link
Contributor
trop bot commented Apr 16, 2021

I have automatically backported this PR to "11-x-y", please check out #28696

@Mario-Kart-Felix Mario-Kart-Felix mentioned this pull request May 17, 2021
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@nornagon nornagon Awaiting requested review from nornagon

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Dialog disappear and doesn't appear again after call hide().
3 participants
@codebytere @jkleinsc @MarshallOfSound
0