8000 fix: crash on invalid select-serial-port callback by trop[bot] · Pull Request #28619 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: crash on invalid select-serial-port callback #28619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2021
Merged

fix: crash on invalid select-serial-port callback #28619

merged 1 commit into from
Apr 12, 2021

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Apr 12, 2021

Backport of #28602

See that PR for details.

Notes: Fixed an issue where select-serial-port callback crashes when called with an invalid serial port ID.

@trop trop bot requested a review from codebytere April 12, 2021 13:20
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 12, 2021
@trop trop bot mentioned this pull request Apr 12, 2021
Merged
4 tasks
@trop trop bot added 13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Apr 12, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Apr 12, 2021
@jkleinsc jkleinsc merged commit b4e70c7 into 13-x-y Apr 12, 2021
@release-clerk
Copy link
release-clerk bot commented Apr 12, 2021

Release Notes Persisted

Fixed an issue where select-serial-port callback crashes when called with an invalid serial port ID.

@trop trop bot deleted the trop/13-x-y-bp-fix-crash-on-invalid-select-serial-port-callback-1618233610673 branch April 12, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkleinsc @codebytere
0