8000 fix: put RemoteCertVerifier upstream from the caching and coalescing layers (#28358) by nornagon · Pull Request #28465 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: put RemoteCertVerifier upstream from the caching and coalescing layers (#28358) #28465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2021
Merged

fix: put RemoteCertVerifier upstream from the caching and coalescing layers (#28358) #28465

merged 1 commit into from
Mar 31, 2021

Conversation

nornagon
Copy link
Contributor

Backport of #28358.

Notes: Fixed a network process crash that could happen when using setCertificateVerifyProc with many concurrent verification requests.

@nornagon nornagon requested a review from a team as a code owner March 31, 2021 17:50
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 31, 2021
@trop trop bot mentioned this pull request Mar 31, 2021
Merged
4 tasks
@trop trop bot added 12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 31, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 31, 2021
@MarshallOfSound MarshallOfSound merged commit 6314637 into 12-x-y Mar 31, 2021
@release-clerk
Copy link
release-clerk bot commented Mar 31, 2021

Release Notes Persisted

Fixed a network process crash that could happen when using setCertificateVerifyProc with many concurrent verification requests.

@MarshallOfSound MarshallOfSound deleted the backport/12-x-y/fix-remote-cert-verifier branch March 31, 2021 20:56
@nornagon
Copy link
Contributor Author

/trop run backport-to 11-x-y

@trop
Copy link
Contributor
trop bot commented Mar 31, 2021

The backport process for this PR has been manually initiated - sending your PR to 11-x-y!

@trop
Copy link
Contributor
trop bot commented Mar 31, 2021

I was unable to backport this PR to "11-x-y" cleanly;
you will need to perform this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nornagon @MarshallOfSound
0