8000 fix: errors thrown in functions over the `contextBridge` by codebytere · Pull Request #28446 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: errors thrown in functions over the contextBridge #28446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2021
Merged

fix: errors thrown in functions over the contextBridge #28446

merged 1 commit into from
Apr 7, 2021

Conversation

codebytere
Copy link
Member

Backport of #28346.

See that PR for details.

Notes: Fixed an issue where errors thrown in functions passed over the contextBridge could be displayed incorrectly.

@codebytere
fix: errors thrown in functions over the contextBridge
e48283a 
* fix: errors thrown in functions over the contextBridge

* spec: add a test

* fix: ensure exception is a v8::Object
@codebytere codebytere requested a review from a team March 30, 2021 16:21
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 30, 2021
@trop trop bot mentioned this pull request Mar 30, 2021
Merged
3 tasks
@trop trop bot added 13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 30, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 30, 2021
@zcbenz zcbenz merged commit fa5bc22 into 13-x-y Apr 7, 2021
@release-clerk
Copy link
release-clerk bot commented Apr 7, 2021

Release Notes Persisted

Fixed an issue where errors thrown in functions passed over the contextBridge could be displayed incorrectly.

@zcbenz zcbenz deleted the fix-errors-thrown-isolated-13 branch April 7, 2021 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
13-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @zcbenz
0