8000 fix: apply tzdata2020f to ICU by miniak · Pull Request #27370 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: apply tzdata2020f to ICU #27370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Jan 19, 2021

Description of Change

We got reports of wrong times displaying for customers in Yukon, Canada.
Update the timezone database in ICU to the latest version to fix this.

Checklist

Release Notes

Notes: Updated the ICU time zone database to the latest 2020f version.

@miniak miniak added semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 12-x-y labels Jan 19, 2021
@miniak miniak self-assigned this Jan 19, 2021
@miniak miniak requested a review from a team as a code owner January 19, 2021 18:27
Copy link
Member
@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miniak why are we fixing it here instead of via Node.js' icu resources? Does it matter?

@zcbenz
Copy link
Contributor
zcbenz commented Jan 21, 2021

@miniak why are we fixing it here instead of via Node.js' icu resources? Does it matter?

Electron's node fork uses Chromium's icu.

@codebytere codebytere merged commit 017628f into 12-x-y Jan 21, 2021
@release-clerk
Copy link
release-clerk bot commented Jan 21, 2021

Release Notes Persisted

Updated the ICU time zone database to the latest 2020f version.

@codebytere codebytere deleted the miniak/tzdata-update-12-x-y branch January 21, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0