8000 fix: make webContents.id work even after destroy by trop[bot] · Pull Request #27070 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: make webContents.id work even after destroy #27070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2021
Merged

fix: make webContents.id work even after destroy #27070

merged 1 commit into from
Jan 5, 2021

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Dec 17, 2020

Backport of #27038

See that PR for details.

Notes: Fixed a crash that could occur on app quit when using the remote module.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Dec 17, 2020 8000
@trop trop bot requested a review from nornagon December 17, 2020 20:11
@trop trop bot mentioned this pull request Dec 17, 2020
Merged
5 tasks
@trop trop bot added 12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Dec 17, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Dec 17, 2020
@zcbenz zcbenz merged commit 0113155 into 12-x-y Jan 5, 2021
@release-clerk
Copy link
release-clerk bot commented Jan 5, 2021

Release Notes Persisted

Fixed a crash that could occur on app quit when using the remote module.

@zcbenz zcbenz deleted the trop/12-x-y-bp-fix-make-webcontents-id-work-even-after-destroy-1608235900609 branch January 5, 2021 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees
No one assigned
Labels
12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zcbenz @MarshallOfSound @nornagon
0