8000 fix: memory leak in desktopCapturer.getSources by nornagon · Pull Request #27031 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: memory leak in desktopCapturer.getSources #27031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2020
Merged

fix: memory leak in desktopCapturer.getSources #27031

merged 1 commit into from
Dec 17, 2020

Conversation

nornagon
Copy link
Contributor

Description of Change

Fixes #21555.

The event listener was never being removed.

Checklist

Release Notes

Notes: Fixed a memory leak in desktopCapturer.getSources.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Dec 15, 2020
@nornagon nornagon added the semver/patch backwards-compatible bug fixes label Dec 15, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Dec 16, 2020
@nornagon nornagon merged commit 6a3679d into master Dec 17, 2020
@release-clerk
Copy link
release-clerk bot commented Dec 17, 2020

Release Notes Persisted

Fixed a memory leak in desktopCapturer.getSources.

@nornagon nornagon deleted the fix-getsources-leak branch December 17, 2020 00:11
@trop
Copy link
Contributor
trop bot commented Dec 17, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

This was referenced Dec 17, 2020
Merged
Merged
@trop
Copy link
Contributor
trop bot commented Dec 17, 2020

I have automatically backported this PR to "11-x-y", please check out #27056

@trop
Copy link
Contributor
trop bot commented Dec 17, 2020

I have automatically backported this PR to "10-x-y", please check out #27057

@trop trop bot mentioned this pull request Dec 17, 2020
Merged
@trop
Copy link
Contributor
trop bot commented Dec 17, 2020

I have automatically backported this PR to "12-x-y", please check out #27058

miniak pushed a commit that referenced this pull request Jan 27, 2021
@nornagon @miniak
fix: memory leak in desktopCapturer.getSources (#27031)
228f074
@miniak miniak mentioned this pull request Jan 27, 2021
Merged
@trop
Copy link
Contributor
trop bot commented Jan 27, 2021

@miniak has manually backported this PR to "9-x-y", please check out #27506

@trop trop bot added the in-flight/9-x-y label Jan 27, 2021
zcbenz pushed a commit that referenced this pull request Jan 27, 2021
@miniak @nornagon
fix: memory leak in desktopCapturer.getSources (#27031) (#27506)
39bea9a 
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniak miniak miniak approved these changes

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

desktopCapturer.getSources memory leaks
4 participants
@nornagon @miniak @codebytere @MarshallOfSound
0