8000 chore: cherry-pick 3a6f6fbfd8 from chromium by deepak1556 · Pull Request #27791 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: cherry-pick 3a6f6fbfd8 from chromium #27791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2021
Merged

chore: cherry-pick 3a6f6fbfd8 from chromium #27791

merged 1 commit into from
Feb 18, 2021

Conversation

deepak1556
Copy link
Member

Stop using raw WebContents ptr in DragDownloadFile

BUG=1172192

(cherry picked from commit 99dc876a13df19f3512bcfb97e794ab5d1b28905)

Change-Id: Ie029713553ff88c1e271db1c84396e1ddda19286
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2666189
Reviewed-by: Xing Liu xingliu@chromium.org
Commit-Queue: Min Qin qinmin@chromium.org
Cr-Original-Commit-Position: refs/heads/master@{#849692}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2692927
Reviewed-by: Shakti Sahu shaktisahu@chromium.org
Cr-Commit-Position: refs/branch-heads/4324@{#2200}
Cr-Branched-From: c73b5a651d37a6c4d0b8e3262cc4015a5579c6c8-refs/heads/master@{#827102}

Notes: Security: backported fix for 1172192.

@deepak1556 deepak1556 requested a review from a team as a code owner February 18, 2021 19:37
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Feb 18, 2021
@deepak1556 deepak1556 added 10-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes labels Feb 18, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Feb 18, 2021
@deepak1556
Copy link
Member Author

Failing test is unrelated, merging.

@deepak1556 deepak1556 merged commit 4f3b520 into 10-x-y Feb 18, 2021
@release-clerk
Copy link
release-clerk bot commented Feb 18, 2021

Release Notes Persisted

Security: backported fix for 1172192.

@deepak1556 deepak1556 deleted the robo/backport_1172192_10_x branch February 18, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@miniak miniak miniak approved these changes

Assignees
No one assigned
Labels
10-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepak1556 @nornagon @miniak
0