8000 fix: check WebContents before emitting render-process-gone event by zcbenz · Pull Request #27730 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: check WebContents before emitting render-process-gone event #27730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2021
Merged

fix: check WebContents before emitting render-process-gone event #27730

merged 1 commit into from
Feb 17, 2021

Conversation

zcbenz
Copy link
Contributor
@zcbenz zcbenz commented Feb 15, 2021

Description of Change

Fix a crash that caused by render-process-gone event accessing WebContents after user has destroyed it in the crashed event.

Checklist

Release Notes

Notes: Fix crash when destroying WebContents in the crashed event.

@zcbenz zcbenz added semver/patch backwards-compatible bug fixes target/12-x-y labels Feb 15, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Feb 15, 2021
@zcbenz zcbenz mentioned this pull request Feb 15, 2021
Merged
5 tasks
@zcbenz
Copy link
Contributor Author
zcbenz commented Feb 15, 2021

This should be merged after #27731, which would fix the CI failure.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Feb 16, 2021
@zcbenz zcbenz force-pushed the render-process-gone-crash branch from 8744d05 to 389e3a4 Compare February 17, 2021 02:00
@zcbenz zcbenz mentioned this pull request Feb 17, 2021
Closed
@zcbenz zcbenz force-pushed the render-process-gone-crash branch from 389e3a4 to 8c6ba88 Compare February 17, 2021 08:39
@zcbenz zcbenz merged commit 7a7a27d into master Feb 17, 2021
@release-clerk
Copy link
release-clerk bot commented Feb 17, 2021

Release Notes Persisted

Fix crash when destroying WebContents in the crashed event.

@zcbenz zcbenz deleted the render-process-gone-crash branch February 17, 2021 12:19
@trop trop bot mentioned this pull request Feb 17, 2021
Merged
@trop
Copy link
Contributor
trop bot commented Feb 17, 2021

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/10-x-y label Feb 17, 2021
@trop trop bot mentioned this pull request Feb 17, 2021
Merged
8000 @trop
Copy link
Contributor
trop bot commented Feb 17, 2021

I have automatically backported this PR to "12-x-y", please check out #27756

@trop
Copy link
Contributor
trop bot commented Feb 17, 2021

I have automatically backported this PR to "11-x-y", please check out #27757

@zcbenz zcbenz mentioned this pull request Feb 17, 2021
Merged
@trop
Copy link
Contributor
trop bot commented Feb 17, 2021

@zcbenz has manually backported this PR to "10-x-y", please check out #27758

@miniak miniak mentioned this pull request Oct 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniak miniak miniak approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zcbenz @miniak @codebytere
0