8000 feat: add session display-capture api option by VerteDinde · Pull Request #27696 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add session display-capture api option #27696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

VerteDinde
Copy link
Member
@VerteDinde VerteDinde commented Feb 10, 2021

Description of Change

Closes #27576.

Chromium introduced a new permission option, display-capture, for sessions. display-capture requests access to capture the screen.

This API is currently in master and was introduced in the 12-x-y line, but as it is a minor change, it is undocumented. This PR documents this change and commits it as a semver minor.

Checklist

Release Notes

Notes: Added display-capture API for session.setPermissionRequestHandler

@VerteDinde VerteDinde added semver/minor backwards-compatible functionality 12-x-y labels Feb 10, 2021
@VerteDinde VerteDinde changed the title feat: add session display-capture api feat: add session display-capture api option Feb 10, 2021
Copy link
Member
@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same text as in master from 8383c14

👍

@ckerr ckerr added the backport-check-skip Skip trop's backport validity checking label Feb 10, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Feb 10, 2021
@codebytere codebytere merged commit 777f23a into 12-x-y Feb 16, 2021
@codebytere codebytere deleted the kmh/session-display-capture branch February 16, 2021 16:00
@release-clerk
Copy link
release-clerk bot commented Feb 16, 2021

Release Notes Persisted

Added display-capture API for session.setPermissionRequestHandler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12-x-y api-review/approved ✅ backport-check-skip Skip trop's backport validity checking semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0