8000 perf: optimize data structures in context_bridge::ObjectCache by MarshallOfSound · Pull Request #27639 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

perf: optimize data structures in context_bridge::ObjectCache #27639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2021
Merged

perf: optimize data structures in context_bridge::ObjectCache #27639

merged 1 commit into from
Feb 8, 2021

Conversation

MarshallOfSound
Copy link
Member
@MarshallOfSound MarshallOfSound commented Feb 5, 2021 •
edited
Loading
  • Use std::forward_list instead of base::LinkedList for better perf, more consistent memory management. Better than std::list because we don't need the double-linked-list behavior of std::list
  • Use std::unordered_map instead of std::map for the v8 hash table

Follow up to #27630

Notes: no-notes

@MarshallOfSound MarshallOfSound requested a review from ckerr February 5, 2021 20:59
@electron-cation electron-cation bot added th 8000 e new-pr 🌱 PR opened recently label Feb 5, 2021
@MarshallOfSound
perf: optimize data structures in context_bridge::ObjectCache
07ea131 
* Use std::forward_list instead of base::LinkedList for better perf,
more consistent memory management.  Better than std::list because we
don't need the double-linked-list behavior of std::list
* Use std::unordered_map instead of std::map for the v8 hash table
@codebytere codebytere added performance 🏁 semver/patch backwards-compatible bug fixes labels Feb 8, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Feb 8, 2021
@MarshallOfSound MarshallOfSound merged commit 09870d9 into master Feb 8, 2021
@release-clerk
Copy link
release-clerk bot commented Feb 8, 2021

No Release Notes

@MarshallOfSound MarshallOfSound deleted the ctx-bridge-optimize branch February 8, 2021 20:30
This was referenced Feb 8, 2021
Merged
Merged
Merged
@trop
Copy link
Contributor
trop bot commented Feb 8, 2021

I have automatically backported this PR to "11-x-y", please check out #27664

@trop trop bot removed the target/11-x-y label Feb 8, 2021
@trop
Copy link
Contributor
trop bot commented Feb 8, 2021

I have automatically backported this PR to "10-x-y", please check out #27665

@trop
Copy link
Contributor
trop bot commented Feb 8, 2021

I have automatically backported this PR to "12-x-y", please check out #27666

@ckerr ckerr mentioned this pull request Aug 31, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniak miniak miniak approved these changes

@codebytere codebytere codebytere approved these changes

@ckerr ckerr Awaiting requested review from ckerr

Assignees
No one assigned
Labels
performance 🏁 semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarshallOfSound @miniak @codebytere
0