8000 fix: clean up base::LinkedList in context_bridge::ObjectCache by trop[bot] · Pull Request #27637 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: clean up base::LinkedList in context_bridge::ObjectCache #27637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2021
Merged

fix: clean up base::LinkedList in context_bridge::ObjectCache #27637

merged 1 commit into from
Feb 5, 2021

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Feb 5, 2021

Backport of #27630

See that PR for details.

Notes: Fixed memory leak when sending non-primitives over the context bridge

@MarshallOfSound @electron-bot
fix: clean up base::LinkedList in context_bridge::ObjectCache
45ddd2b 
base::LinkedList does not delete its members on destruction. We need to
manually ensure the linkedlist is empty when the ObjectCache is
destroyed.

Fixes #27039

Notes: Fixed memory leak when sending non-primitives over the context
bridge
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Feb 5, 2021
@trop trop bot requested a review from MarshallOfSound February 5, 2021 20:39
@trop trop bot mentioned this pull request Feb 5, 2021
Merged
@trop trop bot added 10-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Feb 5, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Feb 5, 2021
@MarshallOfSound MarshallOfSound merged commit a2f7772 into 10-x-y Feb 5, 2021
@release-clerk
Copy link
release-clerk bot commented Feb 5, 2021

Release Notes Persisted

Fixed memory leak when sending non-primitives over the context bridge

@trop trop bot deleted the trop/10-x-y-bp-fix-clean-up-base-linkedlist-in-context_bridge-objectcache-1612557575120 branch February 5, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
10-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarshallOfSound
0