8000 fix: pass button callback in constructor by zcbenz · Pull Request #27545 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: pass button callback in constructor #27545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2021
Merged

fix: pass button callback in constructor #27545

merged 1 commit into from
Jan 29, 2021

Conversation

zcbenz
Copy link
Contributor
@zcbenz zcbenz commented Jan 29, 2021 •
edited
Loading

Description of Change

Fix #26717.

Some recent changes in Chromium made views::Button::SetCallback stop working in views::MenuButton, pass the callback in constructor to make the callback work again. Also this is a better tested code path in Chromium and we will have much less chance running into problems with it.

Checklist

Release Notes

Notes: Fix menubar not clickable on Windows and Linux.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jan 29, 2021
@zcbenz zcbenz added the semver/patch backwards-compatible bug fixes label Jan 29, 2021
@codebytere
Copy link
Member

@zcbenz rebasing will fix failures

@MarshallOfSound MarshallOfSound merged commit 6edf6c6 into master Jan 29, 2021
@release-clerk
Copy link
release-clerk bot commented Jan 29, 2021

Release Notes Persisted

Fix menubar not clickable on Windows and Linux.

@MarshallOfSound MarshallOfSound deleted the fix-menubar branch January 29, 2021 20:43
@trop trop bot mentioned this pull request Jan 29, 2021
Merged
@trop
Copy link
Contributor
trop bot commented Jan 29, 2021

I have automatically backported this PR to "12-x-y", please check out #27555

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Menubar not clickable on Electron 12
3 participants
@zcbenz @codebytere @MarshallOfSound
0