8000 fix: `nativeTheme.themeSource = 'dark'` on windows by ckerr · Pull Request #26237 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: nativeTheme.themeSource = 'dark' on windows #26237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2020
Merged

fix: nativeTheme.themeSource = 'dark' on windows #26237

merged 1 commit into from
Oct 29, 2020

Conversation

ckerr
Copy link
Member
@ckerr ckerr commented Oct 28, 2020

Description of Change

fix: nativeTheme.themeSource = 'dark' on windows iff build flag is enabled. (Disabled by default)

Manually backports #25373.

CC @deepak1556 @electron/wg-releases

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 28, 2020
@trop trop bot mentioned this pull request Oct 28, 2020
Merged
6 tasks
@trop trop bot added 10-x-y backport This is a backport PR labels Oct 28, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 28, 2020
@jkleinsc
Copy link
Member

The releases WG approved this PR for backport to 10-x-y at the Oct 28, 2020 meeting

@jkleinsc jkleinsc merged commit ffd1e9b into 10-x-y Oct 29, 2020
@release-clerk
Copy link
release-clerk bot commented Oct 29, 2020

No Release Notes

@jkleinsc jkleinsc deleted the backport/10-x-y/25373-dark-mode-windows branch October 29, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
10-x-y backport/approved ✅ backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckerr @jkleinsc @codebytere
0