8000 feat: add osProcessId / name properties to webFrameMain by miniak · Pull Request #26093 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add osProcessId / name properties to webFrameMain #26093

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2020
Merged

feat: add osProcessId / name properties to webFrameMain #26093

merged 2 commits into from
Oct 26, 2020

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Oct 22, 2020 •
edited
Loading

Description of Change

This allows removing the private w.webContents._getOSProcessIdForFrame API, which was only used in a test.

Checklist

Release Notes

Notes: Added osProcessId / name properties to webFrameMain.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 22, 2020
@miniak miniak force-pushed the miniak/web-frame-main-pid branch from e3a08da to 933c953 Compare October 22, 2020 02:12
samuelmaddock
samuelmaddock approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member
@samuelmaddock samuelmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This all lgtm. 👍

@miniak miniak force-pushed the miniak/web-frame-main-pid branch from 933c953 to 9204e81 Compare October 22, 2020 02:22
samuelmaddock
samuelmaddock reviewed Oct 22, 2020
View reviewed changes
@miniak miniak changed the title feat: add pid / name properties to webFrameMain feat: add osProcessId / name properties to webFrameMain Oct 22, 2020
@miniak miniak force-pushed the miniak/web-frame-main-pid branch 2 times, most recently from 4adb262 to 7cf798e Compare October 22, 2020 02:47
@miniak miniak force-pushed the miniak/web-frame-main-pid branch from 7cf798e to 72f24c3 Compare October 23, 2020 00:28
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 23, 2020
nornagon
nornagon approved these changes Oct 23, 2020
View reviewed changes
@miniak @nornagon
Update docs/api/web-frame-main.md
c6da6d7 
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
@miniak miniak self-assigned this Oct 23, 2020
@alexeykuzmin alexeykuzmin merged commit aa157c3 into master Oct 26, 2020
@release-clerk
Copy link
release-clerk bot commented Oct 26, 2020

Release Notes Persisted

Added osProcessId / name properties to webFrameMain.

@alexeykuzmin alexeykuzmin deleted the miniak/web-frame-main-pid branch October 26, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelmaddock samuelmaddock samuelmaddock approved these changes

@nornagon nornagon nornagon approved these changes

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miniak @nornagon @alexeykuzmin @samuelmaddock
0