8000 [GSoD] docs: revised the application progress bar feature page by bandantonio · Pull Request #26003 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[GSoD] docs: revised the application progress bar feature page #26003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 23, 2020
Merged

[GSoD] docs: revised the application progress bar feature page #26003

merged 6 commits into from
Oct 23, 2020

Conversation

bandantonio
Copy link
Contributor

Description of Change

Revised the application progress bar feature page, added screenshots indicating different modes, improved overall consistency

Checklist

Release Notes

Notes: Revised the application progress bar feature page, added screenshots indicating different modes, improved overall consistency

@electron-cation electron-cation bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels Oct 16, 2020
zcbenz
zcbenz reviewed Oct 20, 2020
View reviewed changes
Copy link
Contributor
@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might worth mentioning that, on Windows each window can have its own progress bar, while on macOS and Unity the whole app can have only one progress bar.

erickzhao
erickzhao suggested changes Oct 20, 2020
View reviewed changes
erickzhao
erickzhao suggested changes Oct 21, 2020
View reviewed changes
erickzhao
erickzhao approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member
@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing for conciseness

@zcbenz
Copy link
Contributor
zcbenz commented Oct 22, 2020

There are broken link in the doc:

> electron@12.0.0-nightly.20201020 lint:docs-relative-links /home/builduser/project/src/electron
> python ./script/check-relative-doc-links.py

File Location: /home/builduser/project/src/electron/docs/tutorial/progress-bar.md
	Broken links: ../images/macos-progress.bar.png
	Broken links: ../images/linux-progress.bar.png
	Broken links: ../api/browser-window.md#winsetprogressbarprogress
Parsed through 207 files within docs directory and its 51 subdirectories.
Found 3 broken relative links.

@erickzhao erickzhao requested a review from zcbenz October 22, 2020 17:30
@zcbenz zcbenz merged commit 722903f into electron:master Oct 23, 2020
@release-clerk
Copy link
release-clerk bot commented Oct 23, 2020

Release Notes Persisted

Revised the application progress bar feature page, added screenshots indicating different modes, improved overall consistency

zcbenz pushed a commit that referenced this pull request Oct 23, 2020
Revert "docs: revised the application progress bar feature page (#26003…
d52f169 
…)"

This reverts commit 722903f.
erickzhao pushed a commit to erickzhao/ericktron that referenced this pull request Dec 1, 2020
@bandantonio @erickzhao
docs: revised the application progress bar feature page (electron#26003)
ccd797b 
* docs: revised the application progress bar feature page

* docs: fixed mentions, added screenshots to make the guide more consistent

* docs: added an extra phrase about indeterminate mode

* docs: revised paragraph about indeterminate mode

* docs: fixed lint errors, broken links
@bandantonio bandantonio changed the title docs: revised the application progress bar feature page [GSoD] docs: revised the application progress bar feature page Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@erickzhao erickzhao erickzhao approved these changes

Assignees
No one assigned
Labels
documentation 📓
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bandantonio @zcbenz @erickzhao
0