8000 chore: cherry-pick 381c4b5679 from chromium. by ppontes · Pull Request #26832 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: cherry-pick 381c4b5679 from chromium. #26832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

ppontes
Copy link
Member
@ppontes ppontes commented Dec 4, 2020

"Ensure that buffers used by ImageDecoder haven't been neutered."

Since JavaScript may detach the underlying buffers, we need to check
to ensure they're still valid before using them for decoding.

TBR=sandersd

(cherry picked from commit fa93fba6a28d384b0a0cddd63e85eb10cb97bb53)

Test: Updated unittests. Manual test case breaks.
Change-Id: Iefe5f8adf619cd6afdfedcb08a13c2996bfe0d32
Fixed: 1146761
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527542
Commit-Queue: Dale Curtis dalecurtis@chromium.org
Auto-Submit: Dale Curtis dalecurtis@chromium.org
Reviewed-by: Dan Sanders sandersd@chromium.org
Cr-Original-Commit-Position: refs/heads/master@{#825615}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537781
Reviewed-by: Dale Curtis dalecurtis@chromium.org
Cr-Commit-Position: refs/branch-heads/4240@{#1453}
Cr-Branched-From: f297677702651916bbf65e59c0d4bbd4ce57d1ee-refs/heads/master@{#800218}

Release Notes

Notes: Security: backported the fix to CVE-2020-16023: Use after free in WebCodecs.

@ppontes ppontes added 10-x-y backport-check-skip Skip trop's backport validity checking labels Dec 4, 2020
@ppontes ppontes requested a review from a team as a code owner December 4, 2020 14:44
@ppontes ppontes force-pushed the ppontes/cherry-pick/10-x-y/chromium/381c4b5679 branch 2 times, most recently from 2a10634 to 5e37b6f Compare December 4, 2020 19:54
@MarshallOfSound MarshallOfSound added the semver/patch backwards-compatible bug fixes label Dec 4, 2020
@ppontes ppontes force-pushed the ppontes/cherry-pick/10-x-y/chromium/381c4b5679 branch 2 times, most recently from a3b8511 to 9e2172f Compare December 9, 2020 21:21
@ppontes ppontes force-pushed the ppontes/cherry-pick/10-x-y/chromium/381c4b5679 branch from 9e2172f to 86d5f34 Compare December 10, 2020 10:40
@jkleinsc jkleinsc merged commit 135133e into 10-x-y Dec 10, 2020
@release-clerk
Copy link
release-clerk bot commented Dec 10, 2020

Release Notes Persisted

Security: backported the fix to CVE-2020-16023: Use after free in WebCodecs.

@jkleinsc jkleinsc deleted the ppontes/cherry-pick/10-x-y/chromium/381c4b5679 branch December 10, 2020 16:23
jkleinsc pushed a commit that referenced this pull request Feb 4, 2021
* chore: chromium backports M87-1

Contains applicable backports from M87-1 release
CVE-2020-16037
CVE-2020-16041
CVE-2020-16042

* chore: cherry-pick 381c4b5679 from chromium. (#26832)

* fix: message box missing an "OK" button in GTK (#26915)

Co-authored-by: Mimi <1119186082@qq.com>

* chore: cherry-pick d8d64b7cd244 from chromium (#26892)

* chore: cherry-pick 290fe9c6e245 from v8 (#26896)

* docs: add missing deprecated systemPreferences APIs to breaking-changes (#26934)

Co-authored-by: Milan Burda <milan.burda@gmail.com>

* chore: cherry-pick 3abc372c9c00 from chromium (#26894)

* chore: cherry-pick 3abc372c9c00 from chromium

* resolve conflict

* fix: Avoid crashing in NativeViewHost::SetParentAccessible on Windows 10 (#26949)

* fix: Avoid crashing in NativeViewHost::SetParentAccessible on Windows

This fixes #26905. The patch was obtained from @deepak1556, who in turn
got it from the Microsoft Teams folks.

I believe the crash started happening due to the changes in
https://chromium.googlesource.com/chromium/src.git/+/5c6c8e994bce2bfb867279ae5068e9f9134e70c3%5E!/#F15

This affects Electron 9 and later.

Notes: Fix occasional crash on Windows

* Update .patches

* update patches

Co-authored-by: Biru Mohanathas <birunthan@mohanathas.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: Electron Bot <electron@github.com>

* fix: Upload all *.dll.pdb to symbol server (#26964)

Fixes #26961.

Notes: Add Electron DLLs like libGLESv2.dll to symbol server

Co-authored-by: Biru Mohanathas <birunthan@mohanathas.com>

* fix: restrict sendToFrame to same-process frames by default (#26875) (#26927)

* fix: restrict sendToFrame to same-process frames by default (#26875)

* missed a conflict

* fix build

* fix build again

* fix usage of defer

* Bump v10.2.0

* chore: cherry-pick 6763a713f957 from skia (#26956)

* chore: chromium backports M87-1

PR feedback: add links to changes in the upstream

Co-authored-by: Andrey Belenko <anbelen@microsoft.com>
Co-authored-by: Pedro Pontes <pepontes@microsoft.com>
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Mimi <1119186082@qq.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
Co-authored-by: Biru Mohanathas <birunthan@mohanathas.com>
Co-authored-by: Electron Bot <electron@github.com>
Co-authored-by: Michaela Laurencin <35157522+mlaurencin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0