8000 feat: add event.senderFrame property returning the webFrameMain by miniak · Pull Request #26764 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add event.senderFrame property returning the webFrameMain #26764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2020
Merged

feat: add event.senderFrame property returning the webFrameMain #26764

merged 1 commit into from
Dec 9, 2020

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Dec 1, 2020 •
edited
Loading

Description of Change

Also add missing event.processId, which needs to be passed to webFrameMain.fromId().

Checklist

Release Notes

Notes: Added event.senderFrame property returning the originating webFrameMain of the IPC message.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Dec 1, 2020
@miniak miniak force-pushed the miniak/event-process-id branch from 062ab59 to 2ef55ad Compare December 1, 2020 18:46
@miniak miniak marked this pull request as ready for review December 1, 2020 18:47
@nornagon nornagon added api-review/requested 🗳 semver/minor backwards-compatible functionality labels Dec 1, 2020
@miniak miniak force-pushed the miniak/event-process-id branch from 2ef55ad to 99e552d Compare December 1, 2020 19:10
@miniak miniak changed the title feat: add event.processId to be usable with webFrameMain.fromId() feat: add event.frame property returning the originating webFrameMain Dec 1, 2020
@miniak miniak force-pushed the miniak/event-process-id branch 3 times, most recently from 80275f0 to 5da8a4d Compare December 1, 2020 19:40
@miniak miniak changed the title feat: add event.frame property returning the originating webFrameMain feat: add event.senderFrame property returning the webFrameMain Dec 1, 2020
@miniak miniak force-pushed the miniak/event-process-id branch from 5da8a4d to c0f074b Compare December 1, 2020 19:46
@miniak miniak self-assigned this Dec 1, 2020
@miniak miniak force-pushed the miniak/event-process-id branch from c0f074b to 6eb5079 Compare December 1, 2020 21:31
nornagon
nornagon suggested changes Dec 1, 2020
View reviewed changes
@miniak miniak force-pushed the miniak/event-process-id branch from d45e7c3 to 6c0b2e2 Compare December 2, 2020 00:10
nornagon
nornagon approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor
@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@miniak miniak force-pushed the miniak/event-process-id branch from 6c0b2e2 to 0660412 Compare December 2, 2020 00:17
samuelmaddock
samuelmaddock approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member
@samuelmaddock samuelmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getter is going to be very handy. Nice!

lib/browser/api/web-contents.ts
Object.defineProperty(event, 'senderFrame', {
get: () => webFrameMain.fromId(processId, frameId)
});
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@miniak miniak force-pushed the miniak/event-process-id branch 2 times, most recently from 83f8c74 to 0cac7e2 Compare December 2, 2020 02:12
jkleinsc
jkleinsc approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member
@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM as well

@electron-cation electron-cation bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels Dec 2, 2020
@miniak miniak force-pushed the miniak/event-process-id branch from 0cac7e2 to 5bd5f19 Compare December 3, 2020 17:29
@miniak
Copy link
Contributor Author
miniak commented Dec 9, 2020

@nornagon I've noticed that, I had it originally

    dict.Set("processId", frame->GetProcess()->GetID());
    dict.Set("frameId", frame->GetRoutingID());

and then changed it to match your PR to avoid conflict

    dict.Set("frameId", frame->GetRoutingID());
    dict.Set("processId", frame->GetProcess()->GetID());

which broke the snapshot for tests

@miniak miniak force-pushed the miniak/event-process-id branch from aea563c to c75859b Compare December 9, 2020 00:28
@nornagon
Copy link
Contributor
nornagon commented Dec 9, 2020

@miniak the linked PR updates the tests to replace the process id with a placeholder in the snapshot.

@miniak miniak force-pushed the miniak/event-process-id branch from c75859b to c1d6a57 Compare December 9, 2020 19:50
@miniak miniak force-pushed the miniak/event-process-id branch from c1d6a57 to 4a814cd C 8000 ompare December 9, 2020 21:02
@codebytere codebytere merged commit cec6378 into master Dec 9, 2020
@release-clerk
Copy link
release-clerk bot commented Dec 9, 2020

Release Notes Persisted

Added event.senderFrame property returning the originating webFrameMain of the IPC message.

@codebytere codebytere deleted the miniak/event-process-id branch December 9, 2020 23:34
@trop
Copy link
Contributor
trop bot commented Dec 9, 2020

I was unable to backport this PR to "12-x-y" cleanly;
you will need to perform this backport manually.

@miniak
Copy link
Contributor Author
miniak commented Dec 16, 2020

/trop run backport-to 12-x-y

@trop
Copy link
Contributor
trop bot commented Dec 16, 2020

The backport process for this PR has been manually initiated -
sending your commits to "12-x-y"!

@trop
Copy link
Contributor
trop bot commented Dec 16, 2020

I was unable to backport this PR to "12-x-y" cleanly;
you will need to perform this backport manually.

miniak added a commit that referenced this pull request Dec 16, 2020
@miniak
feat: add event.senderFrame property returning the originating webFra…
df33ccb 
…meMain (#26764)
@miniak miniak mentioned this pull request Dec 16, 2020
Merged
@trop
Copy link
Contributor
trop bot commented Dec 16, 2020

@miniak has manually backported this PR to "12-x-y", please check out #27047

zcbenz pushed a commit that referenced this pull request Jan 11, 2021
@miniak
feat: add event.senderFrame property returning the originating webFra…
f5af20d 
…meMain (#26764) (#27047)
@deepak1556 deepak1556 mentioned this pull request Apr 13, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@samuelmaddock samuelmaddock samuelmaddock approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees

@miniak miniak

Labels
api-review/approved ✅ backport/approved ✅ semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@miniak @nornagon @jkleinsc @samuelmaddock @codebytere @VerteDinde @MarshallOfSound
0