8000 chore: remove deprecated crashReporter APIs by miniak · Pull Request #26695 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: remove deprecated crashReporter APIs #26695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2020
Merged

chore: remove deprecated crashReporter APIs #26695

merged 1 commit into from
Nov 26, 2020

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Nov 25, 2020 •
edited
Loading

Description of Change

Remove deprecated crashReporter APIs:

  • crashReporter.start (renderer)
  • crashReporter.getLastCrashReport (renderer)
  • crashReporter.getUploadedReports (renderer)
  • crashReporter.getUploadToServer (renderer)
  • crashReporter.setUploadToServer (renderer)
  • crashReporter.getCrashesDirectory (renderer + main)

These are already documented as removed in Electron 12
Follow-up to #23265

Checklist

Release Notes

Notes: Removed deprecated crashReporter APIs.

@miniak miniak self-assigned this Nov 25, 2020
@miniak miniak requested a review from a team as a code owner November 25, 2020 18:22
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Nov 25, 2020
@miniak miniak force-pushed the miniak/crash-reporter-deprecated-apis branch from cb80e3b to a48d0d1 Compare November 25, 2020 18:26
@miniak miniak force-pushed the miniak/crash-reporter-deprecated-apis branch from a48d0d1 to f75fc9a Compare November 25, 2020 18:39
nornagon
nornagon suggested changes Nov 25, 2020
View reviewed changes
Copy link
Contributor
@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a note in docs/breaking-changes.md.

@nornagon
Copy link
Contributor

Also, I don't see a need for this change to be backported to 12.x.

@nornagon
Copy link
Contributor

apparently these are already documented to be removed in 12.x.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Nov 26, 2020
@alexeykuzmin alexeykuzmin merged commit 022bafc into master Nov 26, 2020
@release-clerk
Copy link
release-clerk bot commented Nov 26, 2020

Release Notes Persisted

Removed deprecated crashReporter APIs.

@alexeykuzmin alexeykuzmin deleted the miniak/crash-reporter-deprecated-apis branch November 26, 2020 19:07
@trop trop bot mentioned this pull request Nov 26, 2020
Merged
@trop
Copy link
Contributor
trop bot commented Nov 26, 2020

I have automatically backported this PR to "12-x-y", please check out #26709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miniak @nornagon @alexeykuzmin
0