8000 fix: make screen wrapper remote-friendly again by trop[bot] · Pull Request #26660 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: make screen wrapper remote-friendly again #26660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2020
Merged

fix: make screen wrapper remote-friendly again #26660

merged 1 commit into from
Nov 23, 2020

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Nov 23, 2020

Backport of #26620

See that PR for details.

Notes: Fixed screen methods not being accessible via remote.screen.

@andersk @electron-bot
fix: make screen wrapper remote-friendly again
04cd38b 
This restores accessibility of screen methods via remote.screen.

Fixes #26610.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Nov 23, 2020
@trop trop bot mentioned this pull request Nov 23, 2020
Merged
5 tasks
@trop trop bot added 11-x-y backport This is a backport PR labels Nov 23, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Nov 23, 2020
Dour420
Dour420 suggested changes Nov 23, 2020
View reviewed changes
Copy link
@Dour420 Dour420 left a comment •
edited by groundwater
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CONTENT DELETED

@jkleinsc jkleinsc merged commit 18cde2e into 11-x-y Nov 23, 2020
@release-clerk
Copy link
release-clerk bot commented Nov 23, 2020

Release Notes Persisted

Fixed screen methods not being accessible via remote.screen.

@trop trop bot deleted the trop/11-x-y-bp-fix-make-screen-wrapper-remote-friendly-again-1606167915272 branch November 23, 2020 23:27
@deanylev deanylev mentioned this pull request Nov 27, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dour420 Dour420 Dour420 requested changes

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
11-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkleinsc @codebytere @Dour420 @andersk
0