8000 fix: segfault on webContents.fromId(xxx) by nornagon · Pull Request #26609 · electron/electron · GitHub

More Web Proxy on the site http://driver.im/

fix: segfault on webContents.fromId(xxx) #26609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

nornagon merged 1 commit into master from web-contents-fromid

Nov 23, 2020

Contributor

nornagon commented

Description of Change

Fixes #26599.

Checklist

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
relevant documentation is changed or added
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Release Notes

Notes: Fixed a crash when calling webContents.fromId with an unknown ID.

electron-cation bot added the new-pr 🌱 label

nornagon added target/11-x-y labels


          fix: segfault on webContents.fromId(xxx)

e786f6f

nornagon force-pushed the web-contents-fromid branch from e2d6fe3 to e786f6f Compare

November 19, 2020 23:04

Contributor Author

nornagon commented

also sent a fix upstream to gin: https://chromium-review.googlesource.com/c/chromium/src/+/2551303

electron-cation bot removed the new-pr 🌱 label

jkleinsc approved these changes

View reviewed changes

nornagon merged commit 329494c into master

release-clerk bot commented

Release Notes Persisted

Fixed a crash when calling webContents.fromId with an unknown ID.

nornagon deleted the web-contents-fromid branch

November 23, 2020 17:21

Contributor

trop bot commented

I was unable to backport this PR to "11-x-y" cleanly;
you will need to perform this backport manually.

trop bot added needs-manual-bp/11-x-y and removed target/11-x-y labels

trop bot mentioned this pull request

fix: segfault on webContents.fromId(xxx) #26651

Merged

Contributor

trop bot commented

I have automatically backported this PR to "12-x-y", please check out #26651

trop bot added in-flight/12-x-y and removed target/12-x-y labels

nornagon mentioned this pull request

fix: segfault on webContents.fromId(xxx) #26652

Merged

Contributor

trop bot commented

@nornagon has manually backported this PR to "11-x-y", please check out #26652

8A2D

trop bot removed the needs-manual-bp/11-x-y label

nornagon added a commit that referenced this pull request


          fix: segfault on webContents.fromId(xxx) (#26609)

324021a

trop bot added in-flight/11-x-y and removed in-flight/11-x-y labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

0