8000 feat: add macOS fast user switching evt by codebytere · Pull Request #25321 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add macOS fast user switching evt #25321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2020
Merged

feat: add macOS fast user switching evt #25321

merged 1 commit into from
Sep 22, 2020

Conversation

codebytere
Copy link
Member

Description of Change

Closes #25039.

Adds fast user switching detection, which occurs when one logs out and then back in again as another user. This is distinct from suspend/resume - since no suspension occurs neither event is fired in this case.

Checklist

Release Notes

Notes: Adds fast user switching event to powerMonitor on macOS.

10000
@electron-cation electron-cation bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels Sep 4, 2020
nornagon
nornagon reviewed Sep 14, 2020
View reviewed changes
nornagon
nornagon suggested changes Sep 14, 2020
View reviewed changes
@codebytere codebytere force-pushed the add-fast-user-switch branch 2 times, most recently from a6f65d6 to 3334a77 Compare September 14, 2020 17:51
@jkleinsc
Copy link
Member

The API WG approved this at the Sept 21, 2020 meeting.

@jkleinsc jkleinsc requested a review from nornagon September 22, 2020 00:25
@codebytere
Copy link
Member Author

Arm failure is:

app module app.requestSingleInstanceLock prevents the second launch of app

and unrelated (this is macOS only)

@codebytere codebytere merged commit 6acf34f into master Sep 22, 2020
@release-clerk
Copy link
release-clerk bot commented Sep 22, 2020

Release Notes Persisted

Adds fast user switching event to powerMonitor on macOS.

@codebytere codebytere deleted the add-fast-user-switch branch September 22, 2020 17:12
@camhart
Copy link
camhart commented Sep 24, 2020

Sorry for the noob question--but how do I know once this makes it released on npm? And will the documentation (https://www.electronjs.org/docs/api/power-monitor) be updated at the same time? (I can easily check the code changes out too if needed).

Thank you for this!!!!

@brondibur brondibur mentioned this pull request Mar 3, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
api-review/approved ✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MacOS powerMonitor events, fast user switching detection
5 participants
@codebytere @jkleinsc @camhart @nornagon @zcbenz
0