feat: add serial api support #25237
Merged
feat: add serial api support #25237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
reviewed
Aug 31, 2020
nornagon
suggested changes
Aug 31, 2020
nornagon
reviewed
Sep 14, 2020
nornagon
reviewed
Sep 14, 2020
nornagon
reviewed
Sep 14, 2020
e2b22c9 to
2ae744c
Compare
|
The API WG reviewed this at the Sept 21, 2020 meeting. |
nornagon
reviewed
Sep 23, 2020
resolves #22478
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
b88cfee to
c171d44
Compare
nornagon
reviewed
Sep 24, 2020
spec-main/chromium-spec.ts
Outdated
| @@ -1457,7 +1457,7 @@ describe('iframe using HTML fullscreen API while window is OS-fullscreened', () | |||
| }); | |||
|
|
|||
| describe('navigator.serial', () => { | |||
| app.commandLine.appendSwitch('enable-experimental-web-platform-features'); | |||
| app.commandLine.appendSwitch('enable-blink-features', 'Serial'); | |||
There was a problem hiding this comment.
can this go in the WebPreferences?
|
Release Notes Persisted
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion h
2C1E
as been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR enables use of the Serial API in Electron by exposing several new events on webContents:
select-serial-port- fired whennavigator.serial.requestPort()is called so that an Electron developer can programmatically select a serial portserial-port-added- fired when a new serial port is detected. Emitted afternavigator.serial.requestPorthas been called andselect-serial-porthas fired if a new serial port becomes available. For example, this event will fire when a new USB device is plugged in.serial-port-removed- fired when a serial port is removed. Emitted afternavigator.serial.requestPorthas been called andselect-serial-porthas fired if a serial port has been removed. For example, this event will fire when a USB device is unplugged.Resolves Serial API support #22478
Checklist
npm testpassesRelease Notes
Notes: Added Serial API support