8000 fix: [a11y] Allow focus to move into an editable combobox's listbox by deepak1556 · Pull Request #25003 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: [a11y] Allow focus to move into an editable combobox's listbox #25003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2020
Merged

fix: [a11y] Allow focus to move into an editable combobox's listbox #25003

merged 2 commits into from
Aug 18, 2020

Conversation

deepak1556
Copy link
Member
@deepak1556 deepak1556 commented Aug 17, 2020 •
edited
Loading

Description of Change

Backports https://chromium-review.googlesource.com/c/chromium/src/+/2303789

Refs microsoft/vscode#104636

Checklist

Release Notes

Notes: [a11y] fix an issue where voiceover doesn't read the first item selected from a ARIA combobox

@deepak1556 deepak1556 requested a review from a team as a code owner August 17, 2020 20:32
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Aug 17, 2020
@deepak1556 deepak1556 requested a review from a team August 17, 2020 20:32
@deepak1556 deepak1556 added 10-x-y backport-check-skip Skip trop's backport validity checking labels Aug 17, 2020
@deepak1556 deepak1556 mentioned this pull request Aug 17, 2020
Merged
7 tasks
@trop
Copy link
Contributor
trop bot commented Aug 17, 2020

@deepak1556 has manually backported this PR to "9-x-y", please check out #25004

@trop trop bot added the in-flight/9-x-y label Aug 17, 2020
@deepak1556 deepak1556 merged commit 7079304 into 10-x-y Aug 18, 2020
@release-clerk
Copy link
release-clerk bot commented Aug 18, 2020

Release Notes Persisted

[a11y] fix an issue where voiceover doesn't read the first item selected from a ARIA combobox

@deepak1556 deepak1556 deleted the robo/fix_a11y_list branch August 18, 2020 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
10-x-y backport-check-skip Skip trop's backport validity checking new-pr 🌱 PR opened recently
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepak1556 @zcbenz @codebytere
0