8000 fix: crash when printing by codebytere · Pull Request #25989 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: crash when printing #25989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2020
Merged

fix: crash when printing #25989

merged 1 commit into from
Oct 19, 2020

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented Oct 16, 2020 •
edited
Loading

Description of Change

Closes #26016.

Ameliorates a crash in printing by updating our printing patch to account for Chromium changes.

Tested with https://gist.github.com/0c1c8affb9262ae83bde4d08d3401f0c.

Checklist

Release Notes

Notes: Fixes a crash seen when printing.

@codebytere codebytere requested a review from a team as a code owner October 16, 2020 03:35
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 16, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 17, 2020
@codebytere
Copy link
Member Author
codebytere commented Oct 19, 2020 •
edited
Loading

session.serviceWorkers getFromVersionID() should report the correct script url and scope

is a known flake which is not affected by this change.

@codebytere codebytere mentioned this pull request Oct 19, 2020
Closed
3 tasks
@codebytere codebytere merged commit c6a6f53 into master Oct 19, 2020
@release-clerk
Copy link
release-clerk bot commented Oct 19, 2020

Release Notes Persisted

Fixes a crash seen when printing.

@codebytere codebytere deleted the fix-print-death branch October 19, 2020 21:31
@trop trop bot mentioned this pull request Oct 19, 2020
Merged
@trop
Copy link
Contributor
trop bot commented Oct 19, 2020

I have automatically backported this PR to "11-x-y", please check out #26047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniak miniak miniak approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling window.print() from BrowserView crashes starting in 11.0-beta12
3 participants
@codebytere @miniak @MarshallOfSound
0